Update on the "fearless refactoring" post from last month: One regression found

Last month I made a post titled 'I finally got to demonstrate "fearless refactoring" in action!' which a lot of folks commented on.

In the spirit of full disclosure, I wanted to share that throughout the changeset of this refactor which included 11 files changed, 597 insertions, and 133 deletions (full diff here), a single regression was found due to a logic error I introduced.

There is a postmortem explaining the regression and the fix for anyone who is interested.

I personally think that this is a very good outcome for the scope of changes introduced in this refactor, and while Rust can't save you from your own logic errors, it can still save you from a hell of a lot. :)